Re: Suspicious code in SVNStatusListCtrl

On 19.01.2011 07:38, Dmitry wrote:
> Hey.
>
> CSVNStatusListCtrl::OnLvnGetInfoTip() currently contains the
> following line of code:
>
> if (GetListEntry(pGetInfoTip->iItem>= 0))
>
> which looks suspicious. "pGetInfoTip->iItem>= 0" evaluates to either
> 0 or 1 so GetListEntry() will try to retrieve one of those entries
> and maybe will return a null pointer.
>
> Is that really what is intended here?

Good catch!
Fixed in r20740.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2699145
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].