Suspicious code in SVNStatusListCtrl

Hey.

CSVNStatusListCtrl::OnLvnGetInfoTip() currently contains the following line of code:

        if (GetListEntry(pGetInfoTip->iItem >= 0))

which looks suspicious. "pGetInfoTip->iItem >= 0" evaluates to either 0 or 1 so GetListEntry() will try to retrieve one of those entries and maybe will return a null pointer.

Is that really what is intended here?

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2699028

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-01-19 07:38:33 CET