Re: Suspicious code in TProc

On 23.11.2010 14:56, Dmitry wrote:
> Hey.
>
> Inside CEditPropertiesDlg::OnBnClickedImport() the following code resides:
>
> int nNameBytes = 0;
> if ((nNameBytes< 0)||(nNameBytes> 4096))
> {
> //do something here
> }
>
> Either the wrong condition is checked or the if-statement is just not needed - the condition will always evaluate to "false". I can't decide how the code should behave in this case.
>
> Could you please think of fixing it?

Fixed in r20530.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2685131
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].