[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Suspicious code in TProc

From: Dmitry <wipedout_at_yandex.ru>
Date: Tue, 23 Nov 2010 16:56:44 +0300

Hey.

Inside CEditPropertiesDlg::OnBnClickedImport() the following code resides:

int nNameBytes = 0;
if ((nNameBytes < 0)||(nNameBytes > 4096))
{
//do something here
}

Either the wrong condition is checked or the if-statement is just not needed - the condition will always evaluate to "false". I can't decide how the code should behave in this case.

Could you please think of fixing it?

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2685090

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-11-23 14:56:54 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.