On 18.11.2010 16:20, Stefan Pavlik wrote:
>> Please note: If you upgrade from an earlier version of TortoiseSVN,
>> you have to run a "repair install" right after the upgrade
>> finishes. To do that, run the installer again and click on the
>> "Repair Installation" button. I'm sorry about the inconvenience.
>>
>> If you want to know why the repair install is required, you can
>> read about the technical details in my post:
>> http://tortoisesvn.net/majorupgrade
>
>
> I am using RegistryValues as Component KeyPath in my MSI installer. I
> am also using major upgrades for every new release. The
> RemoveExistingProducts standard action is scheduled after
> InstallFinalize in my installer. I was trying to reproduce the
> problem mentioned in the blog http://tortoisesvn.net/majorupgrade
> using my product with no success.
>
> So I have tried to create small new package for reproducing and still
> - no problems were observed.
>
> Finally I have decided to compare the TortoiseSVN 1.6.7 and 1.6.8
> installer (decompiling using dark.exe and comparing sources). What I
> found is that you have changed the GUID for OverlayRegistry
> component.
>
> What happens during update 1.6.7 -> 1.6.8 (my opinion): Installation
> of TortoiseSVN 1.6.8 installs new OverlayRegistry component
> (represented with new GUID). Later during RemoveExistingProducts
> phase the old OverlayRegistry component (represented by old GUID) is
> removed since it is no more part of the installer.
>
> The result is that the registry keys/values represented by
> OverlayRegistry component are missing after installation is finished.
> Running repair will again install the new OverlayRegistry component.
> But in this case there is no RemoveExistingProducts phase, thus the
> registry values are not removed.
That is correct. Yes.
But you forgot to test something: if you change a registry entry in a
component that has a registry as its keypath (but not the keypath
registry), then that new/changed reg entries won't get updated unless
you also change the GUID of the component.
That's because the keypath of that component hasn't changed.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2683815
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-11-20 09:46:08 CET