[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Eternal loop in quick_hash

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Thu, 14 Oct 2010 20:06:28 +0200

On 14.10.2010 15:48, Oddvar Kloster wrote:
> I found the following problem in SVNHelpers.cpp, line 119:
>
> const char *local_abspath = path.GetDirectory().GetSVNApiPath(pool);
>
> Here, GetDirectory returns a temp variable. Then GetSVNApiPath returns a pointer to the buffer of a member variable of the temp, which is then deleted. So local_abspath ends up pointing to reclaimed memory.

Fixed in r20303.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2672049
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-10-14 20:07:06 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.