[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Eternal loop in quick_hash

From: Oddvar Kloster <Oddvar.Kloster_at_sintef.no>
Date: Thu, 14 Oct 2010 15:48:17 +0200

I found the following problem in SVNHelpers.cpp, line 119:

const char *local_abspath = path.GetDirectory().GetSVNApiPath(pool);

Here, GetDirectory returns a temp variable. Then GetSVNApiPath returns a pointer to the buffer of a member variable of the temp, which is then deleted. So local_abspath ends up pointing to reclaimed memory.

Oddvar

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2671988

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-10-14 15:49:32 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.