Re: Crash when invoking "show log"

Stefan Küng <tortoisesvn_at_gmail.com> wrote:

> Stefan^2,
>
> Could you please have a look at this?
> I can reproduce the problem here by running
> TortoiseProc.exe /command:log
> /path:"http://agatha-rrsl.googlecode.com/svn/branches/1.1.x"
>
> The crash happens when rev 129 is received, because in
> CacheLogQuery.cpp, line 325 the 'currentPath' is empty/not valid. It got

> reset in line 397. Somehow, the revision got lost.

The reset is not strictly necessary but it is
"safer". Otherwise we won't have detected the
bug behind it:

The log dialog requested "stop on copy" and that
is passed to the SVN query. For some reason, we
receive information after we detected the end of
that path (rev 129 is on /trunk).

> I can't figure out why you reset the path there, so I leave this fix to
you.

Not sure whether I find time to do that today.

-- Stefan^2.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2668523

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-10-06 12:06:49 CEST