Re: New patch

>> I'm not talking about how it is done "behind the scenes", only how it
>> will appear to the end user.
...
>> Is there a particular reason that the patch-code is located
>> in TMerge?
> Yes: we had our own patch code which has nothing to do with svn. So I
> implemented it in TMerge, because that's also where patches get applied.

Allright. I see the logic. As a unix/linux/command line user it makes perfect sense to use a separate tool to perform a part of a task. But as a TSVN user it's not all that clear...
 
>> The only time a tortoise merge window would need to be created would be
>> (as in "Changed Files") when a user wants to view a diff, and the
>> slowdown of starting a new TMerge instance in those cases is OK, I'd
>> say. (We do not share the same TMerge instance for "Changed Files" or
>> for the "Log Messages" dialog.)
> And that would require to start a TMerge instance.
> Sure, we could change it to do so, but I don't like that idea.

I'm not sure that I understand why patching and diffing patched files should be conceptualy (and from a GUI-point of view) different from diffing files changed in a commit, or in a working copy?
 
If the basic problem is starting multiple TMerge instances I would say that doing so from the "Check for modifications" or "Commit" dialog would be a much bigger issue, since that probably is a much more common use case.
 
Hans-Emil

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2615465

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-06-01 08:19:08 CEST