> > 4. If I edit the svn:externals property using the Advanced mode and
> > create an illegal value, then press OK, an error pops up and the
> change
> > is not made. I think it would be better to allow the change and flag
> a
> > warning instead. Sometimes the Advanced mode is more practical, and
> > losing (imperfect) work is annoying.
>
> Showing only a warning but still apply the property would mean to call
> the set-property API twice.
> Also, those errors only show up for svn properties, and I don't think
> allowing invalid values for those properties is a good idea at all,
> even
> if we show a warning.
How about not closing the Edit Property dialog if an error occurs, to give the user a chance to correct his mistake?
>
> > 5. The editor converts old style externals <path> -r <rev> <url> to
> new
> > style externals by setting the peg revision: <url>@<rev> <path>. Is
> > there any reason for this?
>
> Yes: we have to create the property value from various data. Allowing
> the old style would mean writing two completely different functions
> which have the same effect and also writing a parser to find out from
> an
> existing prop value whether it's in old or new format.
> So I just used the new format because that's also the recommended one
> now.
I did not phrase the question carefully enough. Using the new format only is sensible, but why set the peg revision? I would expect a conversion to the format -r <rev> <url> <path>.
Oddvar
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2599846
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-04-30 18:37:22 CEST