Re: A few more niggles in the property editor

On 29.04.2010 13:52, Oddvar Kloster wrote:
> 1. If I open a property in the Edit Property dialog and change its name
> without changing its contents, the press OK, nothing is changed.

fixed in r19396.

> 2. If I open an existing property and change both the property name and
> value, a new property is added with the new name, and the old property
> remains. I would have expected the old property to go away (although
> this is not an important point)

that's by design: that way you can use the values of existing properties
to create new ones.

> 3. If I create a property with the name svn:external and then reopen it
> in the Edit Property dialog, its name is shown as svn:externals.

fixed in r19397.

> 4. If I edit the svn:externals property using the Advanced mode and
> create an illegal value, then press OK, an error pops up and the change
> is not made. I think it would be better to allow the change and flag a
> warning instead. Sometimes the Advanced mode is more practical, and
> losing (imperfect) work is annoying.

Showing only a warning but still apply the property would mean to call
the set-property API twice.
Also, those errors only show up for svn properties, and I don't think
allowing invalid values for those properties is a good idea at all, even
if we show a warning.

> 5. The editor converts old style externals <path> -r <rev> <url> to new
> style externals by setting the peg revision: <url>@<rev> <path>. Is
> there any reason for this?

Yes: we have to create the property value from various data. Allowing
the old style would mean writing two completely different functions
which have the same effect and also writing a parser to find out from an
existing prop value whether it's in old or new format.
So I just used the new format because that's also the recommended one now.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2599823
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].