[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [tortoisesvn] r19341 committed - New feature: searching for revisions in selected range which touch on ...

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sat, 24 Apr 2010 10:15:44 +0200

On 24.04.2010 09:39, tortoisesvn_at_googlecode.com wrote:
> Revision: 19341
> Author: DartRavern
> Date: Sat Apr 24 00:38:24 2010
> Log: New feature: searching for revisions in selected range which touch on
> a chosen file and can include a bug itself or fix of the bug
> http://code.google.com/p/tortoisesvn/source/detail?r=19341

Several problems with this:
* what does this do? Please discuss new features you like to implement
first on the mailing list. Just implementing them is very bad: you don't
know whether that feature should even get into TSVN or maybe someone
else has a better idea!
* you're running diffs on every(!!) shown revision for that file. That's
just insane! Seriously: that's completely out of the question here and
must be removed immediately.
* this doesn't even work: I've tried it on the src/CopyDlg.cpp file in
the TSVN repository and all I got were hundreds of out-of-range exceptions.

I'm sorry, but I will revert this commit. After we've discussed the new
feature on the mailing list you can commit this again but of course
without the diff-on-every-revision part.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2594113
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-04-24 10:15:58 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.