[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Not all overlays appear on Windows 7 with TSVN 1.6.7+

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Tue, 16 Mar 2010 20:18:22 +0100

On 15.03.2010 23:32, Adrian Buehlmann wrote:
> On 15.03.2010 20:51, Valik wrote:
>> On Mar 13, 7:30 pm, Adrian Buehlmann<adr..._at_cadifra.com> wrote:
>>> I'm not convinced that asking the user is a good idea here.
>>> Given Stefan's approach, the unversioned overlay is simply unusable,
>>> because it will never be initialized on Windows 7 and thus defunct.
>> Right, that's my point. On Windows 7 the overlay is unusable. It
>> would be rude of TSVN (or anything using TortoiseOverlays) to just
>> unregister a Windows built-in overlay to make room for the Unversioned
>> overlay. For various reasons it's also impractical to say "It's
>> there, you want to use it, delete something on your own". Removing
>> the overlay as you suggest is certainly one option but the other
>> option is asking the user in a manner I outlined above. Leave it up
>> to the user to determine how they want TSVN to behave. I realize
>> those of you who use the TortoiseOverlays module are still out of luck
>> because, as Stefan mentioned previously, it does not have a GUI
>> component. However, surely there's some way for Stefan to provide a
>> re-usable installer page and pass the settings selected on that page
>> to the TortoiseOverlays module? Even if it's going old school and
>> requiring those of you using TortoiseOverlays to copy a block of code
>> into your installers to get the page, it's still better than removing
>> the overlay.
> I've removed usage of the unversioned overlay from TortoiseHg
> completely. This will be released in 1.0.1, which is due on April 1st.
> So I don't care that much any more (besides the fact that I would be
> interested in TortoiseOverlays not counting a slot for the unversioned
> overlay handler, since we don't use it).
> The numbers of overlay icons "provided" by TortoiseOverlays is too large
> anyway IMHO. And as we have seen, this has consequences.
> The fact is that there are too few available slots on Windows (and even
> fewer on Windows 7). So better don't pretend that TortoiseOverlays can
> take a whopping 9 of them.

I've decided to leave the max. handler check as it is for now. That will
give us 9 overlay slots even on win7 x64.
If we want to remove one handler, I would suggest to remove the 'added'
handler and use the 'modified' handler for added items too.
Or the 'deleted' handler, since deleted files are gone, only deleted
folders would have that overlay.

Or maybe not remove those handlers but just change the code so that
'added' and 'deleted' are the first handlers to go, before the
'unversioned' handler.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-03-16 20:18:26 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.