On 15.03.2010 20:51, Valik wrote:
> On Mar 13, 7:30 pm, Adrian Buehlmann <adr..._at_cadifra.com> wrote:
>> I'm not convinced that asking the user is a good idea here.
>>
>> Given Stefan's approach, the unversioned overlay is simply unusable,
>> because it will never be initialized on Windows 7 and thus defunct.
>
> Right, that's my point. On Windows 7 the overlay is unusable. It
> would be rude of TSVN (or anything using TortoiseOverlays) to just
> unregister a Windows built-in overlay to make room for the Unversioned
> overlay. For various reasons it's also impractical to say "It's
> there, you want to use it, delete something on your own". Removing
> the overlay as you suggest is certainly one option but the other
> option is asking the user in a manner I outlined above. Leave it up
> to the user to determine how they want TSVN to behave. I realize
> those of you who use the TortoiseOverlays module are still out of luck
> because, as Stefan mentioned previously, it does not have a GUI
> component. However, surely there's some way for Stefan to provide a
> re-usable installer page and pass the settings selected on that page
> to the TortoiseOverlays module? Even if it's going old school and
> requiring those of you using TortoiseOverlays to copy a block of code
> into your installers to get the page, it's still better than removing
> the overlay.
>
I've removed usage of the unversioned overlay from TortoiseHg
completely. This will be released in 1.0.1, which is due on April 1st.
So I don't care that much any more (besides the fact that I would be
interested in TortoiseOverlays not counting a slot for the unversioned
overlay handler, since we don't use it).
The numbers of overlay icons "provided" by TortoiseOverlays is too large
anyway IMHO. And as we have seen, this has consequences.
The fact is that there are too few available slots on Windows (and even
fewer on Windows 7). So better don't pretend that TortoiseOverlays can
take a whopping 9 of them.
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2460198
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-03-16 07:13:21 CET