Re: Patch: Subtle defects in FormatMessageWrapper

On 01.02.2010 15:31, Dmitry wrote:
> I gave it another thought - it's not a problem that LocalFree() can alter the "last error", since the retrieval result only depends on the error code and the correct error code value is on the call stack. It is therefore not a defect. Anyway the patch simplifies the interface and effectively removes an unnecessary extra call to FormatMessage() when the wrapper is used in SVN.cpp
>
> The above doesn't recall my concern about uninitialized LPVOID in any way.

Committed in r18494 - but I left the 'relase();' in obtainMessage().

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2443903
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].