Re: Patch: Subtle defects in FormatMessageWrapper
From: Dmitry <wipedout_at_yandex.ru>
Date: Mon, 01 Feb 2010 17:31:22 +0300
I gave it another thought - it's not a problem that LocalFree() can alter the "last error", since the retrieval result only depends on the error code and the correct error code value is on the call stack. It is therefore not a defect. Anyway the patch simplifies the interface and effectively removes an unnecessary extra call to FormatMessage() when the wrapper is used in SVN.cpp
The above doesn't recall my concern about uninitialized LPVOID in any way.
Best wishes.
------------------------------------------------------
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
|
This is an archived mail posted to the TortoiseSVN Dev mailing list.
This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.