Re: Patch: Wrong ownership sematics for BSTRs

On 13.01.2010 07:51, Dmitry wrote:
> Hey.
>
> Here's more - duplication reduction, checking for null pointers,
> using CComPtr. One strange thing I noticed - in MainFrm when
> GetSaveFileName() is called in one case the "window handle" member of
> the structure is set to "this window handle", in another it is left
> null. I had to introduce a function parameter to keep this
> difference. But is this really needed? Shouldn't it be "this window
> handle" each time?

Yes of course, the "this window handle" should be used in both calls.
I've tweaked your patch accordingly.

Committed in r18323.

One small thing: you've introduced the CComPtr to the TortoiseOverlays
project. But that project doesn't use MFC and ATL but only the plain
c-runtime. No other libs - because that's the component used by all
Tortoise clients (not just TortoiseSVN) and I'd like to keep the
dependencies to a minimum and also the size of that component should be
as small as possible.

So no CComPtr for that project.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2437155
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].