Re: Patch: Wrong ownership sematics for BSTRs

Hey.

Here's more - duplication reduction, checking for null pointers, using CComPtr. One strange thing I noticed - in MainFrm when GetSaveFileName() is called in one case the "window handle" member of the structure is set to "this window handle", in another it is left null. I had to introduce a function parameter to keep this difference. But is this really needed? Shouldn't it be "this window handle" each time?

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2436944

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].