Re: [PATCH]: Fix for ambigious Error dialog when unavailable Revision number is used in Log

On 04.01.2010 08:40, Ramasubramanian Sambamurthy wrote:
>> a few comments about this patch:
>
> Thanks for the comments. First of all I would like to wish everyone a
> Very Happy New year :). All corrections are done apart from basic
> clarifications which are explained below.
>
>
>> But there's another thing: GetHEADRevision might contact the
>> repository (especially if log caching is disabled), which we'd like to
>> do only on the thread, not on the UI thread.
>
>
> Yeah, Accessing Repos is costlier but the thing is don't we need to
> compare the m_startrev with HEAD revision, to check whether it is below
> that or not? If yes, isn't that using GetHEADRevision is the only way??
> Or we already have any variable pointing the HEAD revision, as
> GetHEADRevision method is already called before Log information is shown
> (from RepositoryInfo class).
>
> Moreover GetHEADRevision returns -1 or ERR happens when we invoke it for
> show range case again and when the repos is in remote URL.

The head revision is already fetched (the tooltip of the revision button
shows it). So just use that rev number (need to expose the variable or
store it somewhere).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2434672
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].