RE: [PATCH]: Fix for ambigious Error dialog when unavailable Revision number is used in Log

>a few comments about this patch:

Thanks for the comments. First of all I would like to wish everyone a
Very Happy New year :). All corrections are done apart from basic
clarifications which are explained below.

>But there's another thing: GetHEADRevision might contact the
>repository (especially if log caching is disabled), which we'd like to
>do only on the thread, not on the UI thread.

Yeah, Accessing Repos is costlier but the thing is don't we need to
compare the m_startrev with HEAD revision, to check whether it is below
that or not? If yes, isn't that using GetHEADRevision is the only way??
Or we already have any variable pointing the HEAD revision, as
GetHEADRevision method is already called before Log information is shown
(from RepositoryInfo class).

Moreover GetHEADRevision returns -1 or ERR happens when we invoke it for
show range case again and when the repos is in remote URL.

Thanks & Regards,
S V Ramasubramanian

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2434533

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-01-04 08:40:27 CET