[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Repobrowser rename minor bugs

From: Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de>
Date: Wed, 9 Sep 2009 13:07:57 +0200

Stefan Küng <tortoisesvn_at_gmail.com> wrote:

> On 08.09.2009 12:32, Hans-Emil Skogh wrote:
> > >> Renaming a folder in the Repository Browser is a bit funky. First
> > got an
> > >> hourglass icon and could not interract with the commit dialog that
> > opened
> > >> until I switched to another application and back again.
> > > Hm. I couldn't reproduce that -- neither for the list view nor the
> > tree view.
> > > Is that a permanent phenomenon?
> > More details: It only happens when I click somewhere in the repo
> > to "accept" the new name. When pressing enter to confirm the rename
> > everything works as expected.
> > To reproduce:
> > - Right click a folder
> > - Choose "Rename"
> > - Enter new name
> > - Click somewhere in the window
> > - Observe strangeness :-)
> That has been reported before. Unfortunately, I couldn't find a solution

> even after spending several hours (days actually) on this. If someone
> else has an idea on why that happens and how to fix it, be my guest!

I suspect that the mouse click event will cause the
repository browser window to be activated / focussed.
That activation event may not be processed until
DoModal() created a new message loop .. or something
to that effect.

r17144 introduces a hack that simulates toggling
back and forth between the windows. Since that may
cause flicker, I made it optional so that the caller
may activate the work-around only when necessary.

The reported problem should be fixed, now.

-- Stefan^2.


To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-09-09 13:08:19 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.