[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch\bug: when entering unvers. dir with versioned subdirs, subdirs get status-none

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 04 Sep 2009 18:29:34 +0200

On 04.09.2009 01:11, Gunnar Dalsnes wrote:
> Never got a reply to
> http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2388701.

Sorry about that. I started a new job this week and have been very busy.

> Patch fix a bug introduced in r16659 (Prevent a stack overflow under
> certain circumstances by preventing an endless recursion if the path
> doesn't change). This change effectively disabled 'return
> dirEntry->GetStatusForMember(path,bRecursive)', because
> (!dirEntry->m_directoryPath.IsEquivalentToWithoutCase(path)) can
> never be true. This cause (initial) status to always be status-none
> for WC base folders.
> Patch uses mush simpler\better logic to prevent (infinite)
> recursion.

Thanks for your patch. You're right this is a much better way to prevent
the infinite loop.
Committed in r17118.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-09-04 18:29:45 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.