Re: Patch: reducing amount of duplicate code

Hey.

Meanwhile I've factored out some other common code. Also in FileDropEdit.h there's a loop condition:

(hr==S_OK && cbRead >0) && SUCCEEDED(hr))

the problem here is that "hr==S_OK" implies "SUCCEEDED(hr)", so it is equivalent to just

(hr==S_OK && cbRead > 0)

however I'm not sure what the original intent was - should it be testes for == S_OK or for SUCCEEDED()? There're cases when COM methods return HRESULTs different from S_OK but still evaluating SUCCEDED() to "true".

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2391012

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].