Re: TSVNCache memory leaks

Stefan Fuhrmann wrote:
> Stefan Küng wrote:
>> Stefan Fuhrmann wrote:
>>> Stefan Küng wrote:
>>>> Stefan Fuhrmann wrote:
>>>>> * someone is writing to deleted data, possibly in
>>>>> CDirectoryWatcher::CloseInfoMap
>>>> I thought I fixed that just this afternoon?
>>>> It happened the WorkerThread(): if GetQueuedCompletionStatus()
> succeeds,
>>>> the pdi variable could still point to already deleted memory. That's
> why
>>>> I added the check whether the pdi data is still in the watchInfoMap.
>>>>
>>>> But if you still get such debug exception, I guess then it's not
> fixed
>>>> yet :(
>>> It took some hours of analysis and frantic clicking
>>> (to provoke the heap corruption) to identify and fix
>>> the race-conditions.
>> got one more done in r16030.
>
> Hm. I don't think it is necessary to lock for the pdi access:
> It is part of CDirWatchInfo, which is guaranteed to remain
> valid until CleanupWatchInfo() is called.

Better safe than sorry :)

>
>> Should we merge these (your and mine) changes back to 1.6.x? I think we
>> should.
>
> Absolutely. But maybe we should defer the merger until
> Monday or so - just in case something important broke.

I'd say I merge saturday - will run with this until then. I'd like to
upload another 1.6.x nightly with this change and have more people test
this too.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=1532936
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].