Re: DUG Review

Simon Large wrote:
> > * 4.25.2. Changing the View:
> > Maybe note that rows may now overlap (see also
> > Figure 4.46). Different rows are placed at least
> > 10 units (10 pixels @ 100%) apart. The row base line
> > is the node side facing the earlier revision.
>
> Does the user need to know about this?

The DUG speaks of 'rows' (under the 'Group branches' option)
and 'strict row ordering'. In, 1.6 rows will still be ordered strictly
by revision but they may partly overlap to save vertical space.

So, this is more like "managing expectations". IMHO, the current
description is wrong or at least misleading. A slightly different
wording may be sufficient.

> > * 4.25.3 Using the Graph:
> > "Caution" note still required?
>
> Not sure. Subversion doesn't provide definitive information, so aren't
> you still doing some guesswork in the case of large scale tree
> re-organizations?

The construction is fully deterministic and no information is missing
in the log. It copes even with such strange constructs like branches
being accidentally created *inside* other branches.

I guess, the comment was added for pre-1.5 graphs that tried clever
grouping of branches etc. Anyway, r15673 replaces the warning with
a couple of hints for first-time users.

> Feel free to review the changes and make sure I haven't made things
> less clear ;-)

Only some minor stuff, see r15672.

-- Stefan^2.
Received on 2009-03-13 22:36:23 CET