[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch: darker statistics line graph colors

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Thu, 25 Sep 2008 18:16:06 +0200

Aras Pranckevièius wrote:
>> Thanks for the patch. Looks good except for one thing: you're using
>> hardcoded values for correcting the colors.
>> Can you maybe change this to something better?
>
> Well, the old code was using hardcoded values for Luminance and
> Saturation (specifically, L would be 120 or 180 on 0..240 scale). I
> changed L to be lower when on light background. So yes, it adds
> another hardcoded value, but "how much to darken it" should be
> hardcoded (or otherwise defined) _somewhere_. In IntenseColor()-like
> case, I'd have to hardcode 'scale'...

You're right.
Committed your patch in r14105.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net

Received on 2008-09-25 18:17:26 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.