Re: Patch: darker statistics line graph colors
Aras Pranckevièius wrote:
>> Thanks for the patch. Looks good except for one thing: you're using
>> hardcoded values for correcting the colors.
>> Can you maybe change this to something better?
> Well, the old code was using hardcoded values for Luminance and
> Saturation (specifically, L would be 120 or 180 on 0..240 scale). I
> changed L to be lower when on light background. So yes, it adds
> another hardcoded value, but "how much to darken it" should be
> hardcoded (or otherwise defined) _somewhere_. In IntenseColor()-like
> case, I'd have to hardcode 'scale'...
Committed your patch in r14105.
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
Received on 2008-09-25 18:17:26 CEST
This is an archived mail posted to the TortoiseSVN Dev