[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch: darker statistics line graph colors

From: Aras Pranckevičius <nearaz_at_gmail.com>
Date: Thu, 25 Sep 2008 00:49:41 -0700 (PDT)

> Thanks for the patch. Looks good except for one thing: you're using
> hardcoded values for correcting the colors.
> Can you maybe change this to something better?

Well, the old code was using hardcoded values for Luminance and
Saturation (specifically, L would be 120 or 180 on 0..240 scale). I
changed L to be lower when on light background. So yes, it adds
another hardcoded value, but "how much to darken it" should be
hardcoded (or otherwise defined) _somewhere_. In IntenseColor()-like
case, I'd have to hardcode 'scale'...

--
Aras Pranckevičius
work: http://unity3d.com
home: http://aras-p.info
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-09-25 09:50:09 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.