Re: Bug in Update notification code

Jan Rysavy wrote:
> Hi,
>
> We implemented support for receiving SHCNE_UPDATEITEM notifications
> into our file manager and found one problem in latest TSVN.
>
> You can find it in TSVNCache\ShellUpdater.cpp:
> // first send a notification about a sub folder change, so explorer doesn't discard
> // the folder notification. Since we only know for sure that the subversion admin
> // dir is present, we send a notification for that folder.
> CString admindir = workingPath.GetWinPathString() + g_SVNAdminDir.GetAdminDirName();
> SHChangeNotify(SHCNE_UPDATEITEM, SHCNF_PATH | SHCNF_FLUSHNOWAIT, (LPCTSTR)admindir, NULL);
> SHChangeNotify(SHCNE_UPDATEITEM, SHCNF_PATH | SHCNF_FLUSHNOWAIT, workingPath.GetWinPath(),
> NULL);
>
> Please look at 'admindir' variable. Uou should ensure there is backslash
> between the workingPath.GetWinPathString() and g_SVNAdminDir.GetAdminDirName().
>
> Right now we are receiving:
> SHCNE_UPDATEITEM: C:\!test_tortoise_SVN.svn
> SHCNE_UPDATEITEM: C:\!test_tortoise_SVN
>
> Could you please look at this problem and let us know?

Thanks for the report!
Fixed in r13704.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net