[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Bug in Update notification code

From: Jan Rysavy <jan.rysavy_at_altap.cz>
Date: Wed, 13 Aug 2008 10:37:27 +0200

Hi,

We implemented support for receiving SHCNE_UPDATEITEM notifications
into our file manager and found one problem in latest TSVN.

You can find it in TSVNCache\ShellUpdater.cpp:
// first send a notification about a sub folder change, so explorer doesn't discard
// the folder notification. Since we only know for sure that the subversion admin
// dir is present, we send a notification for that folder.
CString admindir = workingPath.GetWinPathString() + g_SVNAdminDir.GetAdminDirName();
SHChangeNotify(SHCNE_UPDATEITEM, SHCNF_PATH | SHCNF_FLUSHNOWAIT, (LPCTSTR)admindir, NULL);
SHChangeNotify(SHCNE_UPDATEITEM, SHCNF_PATH | SHCNF_FLUSHNOWAIT, workingPath.GetWinPath(),
NULL);

Please look at 'admindir' variable. Uou should ensure there is backslash
between the workingPath.GetWinPathString() and g_SVNAdminDir.GetAdminDirName().

Right now we are receiving:
SHCNE_UPDATEITEM: C:\!test_tortoise_SVN.svn
SHCNE_UPDATEITEM: C:\!test_tortoise_SVN

Could you please look at this problem and let us know?

Best regards

Jan Rysavy
ALTAP
Czech Republic
http://www.altap.cz/
mailto:jan.rysavy_at_altap.cz
Tel.: +420 487 725 132

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-08-13 10:37:37 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.