[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Using start_commit_hook to autocreate logtemplate

From: Carsten Johnsen <carsten.johnsen_at_polycom.com>
Date: Thu, 24 Apr 2008 22:50:03 -0700 (PDT)

On 24 Apr., 11:36, "Simon Large" <simon.tortoise..._at_googlemail.com>
wrote:
> The problem with setting a logminsize based on the template size is
> that in some cases (not in yours) the template will consist of
> boilerplate which requires the irrelevant sections to be deleted, so
> the final log message size may actually be smaller than the template.

I knew there was something I missed. No problem.

> One idea which occurs to me is that if the logminsize property is set
> to 0, simply require that some change is made to the message. It's not
> perfect, but it might help.

But you might set logminsize to 0 to allow empty commit-messages. I
can't think of any reason to allow empty messages, but I'm sure it
would be at problem for someone if this was implemented :o)

Another thought:
It is my impression that TSVN doesn't gather any information before
running start_commit_hook.

If this is the case I can see it is not possible to pass the current
logminsize to the hook. Instead TSVN could pass a filepath to the hook
script, where the hook could write a logminsize value to overrule the
property.

Another possibility would be for the hook to write "commands" in the
messagefile. Writing <tsvn:logminsize=101> would then overrule the
property from the WC.

Looking back at this mail I can see this might be difficult to
implement in a simple and straight-forwarded way.

Anyway - just my $0.02 .

/Carsten

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-04-25 07:52:22 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.