Re: [PATCH] Use customizable font in TortoiseUDiff

Kazutoshi Satoda wrote:
> Hi,
>
> I noticed that the new TortoiseUDiff can't correctly render Japanese
> characters. The attached patch replaces the hardcoded font setting to
> one for TortoiseBlame which can be set from Settings dialog.
>
> Proposed log message:
> [[[
> Replaced the hardcoded font setting in TortoiseUDiff to customizable
> one so that users can let TortoiseUDiff correctly render localized
> characters.
> ]]]
>
> I can build TortoiseUDiff with VC++2008EE. I tested this patch on
> Windows XP, Japanese, and it works fine.

Thanks for the patch!
Committed in r12236.

> Using TortoiseBlame's setting in TortoiseUDiff looks odd. Is it easy to
> add a separated setting pane for TortoiseUDiff like TortoiseBlame?

I think it would look ugly to have an almost empty settings page. But
it's not hard to add a new one:
* create a new property page in the resource editor
* resize that new page *exactly* to the same size as the other settings
pages
* copy the cpp/h file from another settings page and modify it to the
new page (that's easier than let the resource editor create the files
for you and adjust them from there).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net