Hi,
I noticed that the new TortoiseUDiff can't correctly render Japanese
characters. The attached patch replaces the hardcoded font setting to
one for TortoiseBlame which can be set from Settings dialog.
Proposed log message:
[[[
Replaced the hardcoded font setting in TortoiseUDiff to customizable
one so that users can let TortoiseUDiff correctly render localized
characters.
]]]
I can build TortoiseUDiff with VC++2008EE. I tested this patch on
Windows XP, Japanese, and it works fine.
Using TortoiseBlame's setting in TortoiseUDiff looks odd. Is it easy to
add a separated setting pane for TortoiseUDiff like TortoiseBlame?
--
k_satoda
Index: src/TortoiseUDiff/MainWindow.cpp
===================================================================
--- src/TortoiseUDiff/MainWindow.cpp (ƒŠƒrƒWƒ‡ƒ“ 12233)
+++ src/TortoiseUDiff/MainWindow.cpp (ì‹ÆƒRƒs[)
@@ -280,7 +280,12 @@
m_directPointer = SendMessage(m_hWndEdit, SCI_GETDIRECTPOINTER, 0, 0);
// Set up the global default style. These attributes are used wherever no explicit choices are made.
- SetAStyle(STYLE_DEFAULT, ::GetSysColor(COLOR_WINDOWTEXT), ::GetSysColor(COLOR_WINDOW), 10, "Courier New");
+ SetAStyle(STYLE_DEFAULT, ::GetSysColor(COLOR_WINDOWTEXT), ::GetSysColor(COLOR_WINDOW),
+ // Reusing TortoiseBlame's setting which already have an user friendly
+ // pane in TortoiseSVN's Settings dialog, while there is no such
+ // pane for TortoiseUDiff.
+ CRegStdWORD(_T("Software\\TortoiseSVN\\BlameFontSize"), 10),
+ WideToMultibyte(CRegStdString(_T("Software\\TortoiseSVN\\BlameFontName"), _T("Courier New"))).c_str());
SendEditor(SCI_SETTABWIDTH, 4);
SendEditor(SCI_SETREADONLY, TRUE);
LRESULT pix = SendEditor(SCI_TEXTWIDTH, STYLE_LINENUMBER, (LPARAM)"_99999");
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-03-01 18:30:25 CET