Sean Leonard wrote:
> Hi Stefan,
>
> Please find the test repository as revin.dump. It has several features:
> * rev 0 = svn:log
> * rev 2 = no changeset (but has a log entry and date and such)
> * rev 4 = no changeset and no log (also no date or author, thus
> completely blank)
>
> Take a look at the log output (via the latest svn log) and the PNG to
> compare. I am using r12047 build, the latest nightly (not the latest
> revision with your most recent changes). It looks like the cache is
> doing something strange and repeating log entries at the top.
>
> For reference, I do not think that 1.4.7 has this problem. I recall that
> when I was testing it earlier this week, I tried inserting some empty
> changeset revisions and it appeared okay.
Thanks for the test repo.
Apart from two little bugs which surfaced due to the 'empty' revision,
my changes from today already made this work.
As for 1.4.7, yes this worked there, but not good enough: the empty
revision still had a valid (but wrong) date shown.
> Finally, I wanted to mention that I think that your code is perfectly
> reasonable at SVNLogQuery.cpp:
> // treat revision 0 special: only report/show it if either the
> author or a message is set, or if user props are set
> if
> ((log_entry->revision)||(userRevProps.GetCount())||(!standardRevProps.author.IsEmpty())||(!standardRevProps.message.IsEmpty()))
>
>
> and in fact probably makes more sense than the svn log behavior, which
> is to display the rev 0 log entry iff svn:log is set. It seems more
> reasonable that if the repository owner (like me!) goes to the trouble
> of specifying svn:author but not svn:log, for example, that the owner
> would *want* the author information reported in the log list. But
> perhaps it is a good idea to note somewhere (either as a comment in the
> source code, or in the bug fix changelog that users can see? up to you)
> that this behavior is more inclusive of showing changes than the svn log.
I don't think that's necessary: there are not many people who use both
TSVN and the CL client. And those who do usually don't care about
revision 0 :-)
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
Received on 2008-02-07 21:02:54 CET