[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11881 - trunk/src: Resources TortoiseProc

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sun, 20 Jan 2008 09:15:46 +0100

Alexander Klenin wrote:
>> // make columns width fit
>> - if (iFirstResized < 30)
>> + if (iFirstResized < 2)
>> {
>> - // only resize the columns for the first 30 or so entries.
>> - // after that, don't resize them anymore because that's an
>> - // expensive function call and the columns will be sized
>> - // close enough already.
>> ResizeColumns();
>> iFirstResized++;
>> }
>
> I wonder why you removed the comment?
> If ResizeColumns() is not expensive any more,
> then perhaps it should be called for all items?

I removed the comment while testing different approaches to the problem.
I've added it again now.

>
>> + if (!data->bAuxItem)
>> + {
>
> It seems that data->bAuxItem is true for 'External' items, so
> external paths no dot get compacted. Am I correct?

the data->bAuxItem is only true for the entry "External | path", which
is the first entry when externals are affected. All sub-items affected
in the externals don't have the bAuxItem set to true (the first item is
only a notification, that the operation is now working on that external,
and it shows up even if there's nothing to do in the externals).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-01-20 09:16:01 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.