[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [nightly build r11440] Revison Graph doesn't show Author, Date, and logmessage

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-11-27 19:52:29 CET

Stefan.Fuhrmann@etas.com wrote:

> I am *very* busy right now, so this has to wait until weekend :/
> However, I suspect that your "logcache as member of SVN" patch
> has broken it: the query that will fill the cache may use a
> different cache instance than the other query. Since changes are
> not written do disk immediately, they may not be visible to all
> or may even get overwritten.

Small update of what I found:

I don't think it has anything to do with my commit making the cache a
non-static member. It really seems as if this never really worked
properly if there was no cache on disk.

The CRevisionInfoContainer has a member array containing the sum (OR)
changes of a revision. That array is calculated by the
CalculateSumChanges() method: but that method is only called when the
cache is loaded from disk!

When adding revisions one-by-one in memory (not from the load-from-disk
operator), then the sumChanges array isn't properly updated --> the
revision graph misses all the copies.

I first thought of just calling CalculateSumChanges() after fetching the
log, but it's a private method. Which means I'd have to make that method
public (not a problem though). But I guess it should be possible to
update sumChanges directly when adding a new revision to the cache. Or
in the UpdateChanges() method which is called at the end of log fetching.

I better leave this to you to decide where the sumChanges array should
be updated best.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Nov 27 19:52:52 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.