[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [nightly build r11440] Revison Graph doesn't show Author, Date, and logmessage

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-11-27 18:48:11 CET

Stefan.Fuhrmann@etas.com wrote:
> Stefan Küng <tortoisesvn@gmail.com> wrote on 26.11.2007 21:29:05:
>> masaru tsuchiyama wrote:
>>> Hi.
>>>>> I found a bug on
> TortoiseSVN-
>>>>> When I show Revison Graph for a repository, it doesn't show Author,
> Date,
>>>>> and logmessage correctly.
>>>>> Author and revision log are empty, and Date is Jan 1 1970.
>>>> Fixed in revision 11446.
>>> Thank you. I confirmed that it is fixed.
>>> But I found another bug on Revision Graph at
>>> TortoiseSVN-
>>> This is the steps.
>>> 1. Select TortoiseSVN -> Settings
>>> 2. Select "Saved Data" and click "Clear" on "Log messages (Show Log
> Dialog).
>>> 3. Select "Repository Browser" and enter
> http://svn.collab.net/repos/svn/trunk
>>> 4. Right click at "trunk" and select "Revison Graph"
>>> 5. There is no branch and tag. <==
>>> 6. Close the window.
>>> 7. Select "Repository Browser" and enter
>>> http://svn.collab.net/repos/svn/trunk again.
>>> 8. Right click at "trunk" and select "Revison Graph"
>>> 9. You can find branches and tags.
>> Yes, I can reproduce the problem. However, even after three hours now
>> debugging the cache code, I can't find why this happens.
>> Before I go nuts here, I think it's best if Stefan^2 has a look a this.
>> Stefan^2 ? Can you please check what's going on here?
>> It seems as if the cache when written to from the log callback hasn't
>> the same data as when it's loaded from disk. Somewhere at least one
>> variable/object isn't properly set when not loaded from disk.
>> Stefan
> I am *very* busy right now, so this has to wait until weekend :/

No problem.

> However, I suspect that your "logcache as member of SVN" patch
> has broken it: the query that will fill the cache may use a

I suspected the same. But the logcache really must not be a static
member (see my log message and the commend I added to know why).

> different cache instance than the other query. Since changes are
> not written do disk immediately, they may not be visible to all
> or may even get overwritten.

Yes, I tried saving and reloading the cache after fetching the log: that
made it work. But of course, that's not really an option.
I've also checked the address in memory where the cache is located: it's
the same when fetching the log and later when analyzing the data: that's
why I suspect that something isn't initialized properly when updating
the cache in memory - when loading from the disk everything seems to
work so there must be some initializing which doesn't happen when the
cache is created in ram.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Nov 27 18:48:30 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.