[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH/RFC] Replace RichEdit with Scintilla in log dialog

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-10-17 20:19:09 CEST

Alexander Klenin wrote:

>> You shouldn't put bugtraq: specific code in the scintilla control class.
>> That's something unrelated. Instead, just extract the url and send a
>> notification back to the parent window. Just like the rich edit control
>> does.
> I agree in principle, but, as currently implemented, SciEdit already
> depends heavily
> on bugregex specifics.
> At the same time, notification code will be duplicated at all SciEdit
> users, which is a lot.
> I propose to implement this in SciEdit for now, and then later
> refactor it out together
> with bugregex code. Maybe add a derived class SciEditBugID, or some other way.

Fine with me. I completely forgot that we already have bugtraq: specific
code in that class - seems I missed to clean up that class...


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Oct 17 20:19:21 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.