[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH/RFC] Replace RichEdit with Scintilla in log dialog

From: Alexander Klenin <klenin_at_gmail.com>
Date: 2007-10-17 19:54:13 CEST

On 10/18/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
> But the editing should be disabled until the user either doubleclicks on
> the control or presses a special button. Otherwise, accidental log
> message changes would happen.
Sure, the interface I'm planning will protect against accidental edits.

> > 3) This, in turn, would allow to remove InputDlg, since it is used
> > (almost) only here.
> >
> > It is not complete yet, because:
> > 1) There is a small regression -- URL auto-recognition is lost.
> > It must be re-implemented using custom regexp in SciEdit.
> > I will do that, but it will require some time.
> That's not a big problem.

> Keep in mind that Scintilla is not fully unicode aware. We might get
> into troubles with this - but then the commit dialog uses it too and we
> haven't heard of any complaints there either.
Yes, and current 'Edit log message' dialog uses it too.

> > 2) Should I file an issue?
> Yes please.
Filed issue #407.

> As long as it compiles, commit it to the trunk.

> Why do you remove the property reading?
I just moved it a few lines up, so properties are available to
m_cLogMessage.Init call.

> * always add a tab to indent after an {
> * the break should be after the closing }
Will fix. Braces were added just a quickfix for
"C2360: initialization of is skipped by 'case' label" compiler error which
appeared after I added new case label.

> You shouldn't put bugtraq: specific code in the scintilla control class.
> That's something unrelated. Instead, just extract the url and send a
> notification back to the parent window. Just like the rich edit control
> does.
I agree in principle, but, as currently implemented, SciEdit already
depends heavily
on bugregex specifics.
At the same time, notification code will be duplicated at all SciEdit
users, which is a lot.
I propose to implement this in SciEdit for now, and then later
refactor it out together
with bugregex code. Maybe add a derived class SciEditBugID, or some other way.

Alexander S. Klenin
Insight Experts Ltd.
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Oct 17 19:54:21 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.