[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Refactor CBalloon code

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-09-06 19:33:11 CEST

Alexander Klenin wrote:
> On 9/6/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
>> Alexander Klenin wrote:
>>> 1) Is there a useful case when m_pParentWnd == NULL?
>>> If not, the assertion can be added to Create() function and the rest
>>> of the code simplified.
>> Yes, every time there isn't a parent dialog/window available and we'd
>> like to show a balloon. Ok, we don't use this currently, but we might in
>> the future.
> Isn't it taken care of by
> if (pWnd == NULL)
> pWnd = GetDesktopWindow();
> lines in ShowBalloon?

I guess so. Remember that code is pretty old :)

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Sep 6 19:30:08 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.