Re: [PATCH] Refactor CBalloon code

On 9/6/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
> Alexander Klenin wrote:
> > 1) Is there a useful case when m_pParentWnd == NULL?
> > If not, the assertion can be added to Create() function and the rest
> > of the code simplified.
>
> Yes, every time there isn't a parent dialog/window available and we'd
> like to show a balloon. Ok, we don't use this currently, but we might in
> the future.
Isn't it taken care of by
        if (pWnd == NULL)
                pWnd = GetDesktopWindow();
lines in ShowBalloon?

> If that restricts something you like to do, you can of course remove it.
Not at all, just seemed unnecessary to me.

> > 5) Out of six defined overloads for ShowBalloon function, only one is
> > actually used, and each caller passes GetCtrlCentre as a second
> > argument.
> > I understand that interface was intended to be general, but perhaps it
> > is a little overkill? Should I simplify it and reduce the number of
> > overloads?
>
> Yes, please do.
Done.

-- 
Alexander S. Klenin
Insight Experts Ltd.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org