[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Feature request: right-to-left alignment in commit dialog

From: Ori Avtalion <oavtal_at_bezeqint.net>
Date: 2007-08-18 20:32:32 CEST

Stefan K√ľng wrote:
> Ori Avtalion wrote:
>
>> I checked the nightly build and noticed several problems:
>>
>> 1) Text in the Ctrl+R mode comes out mirrored, while the desired
>> result is just a reordering of the text flow.
>>
>> See this picture of TSVN's dialog alongside Notepad:
>> <http://www2.mta.ac.il/~oravtali/tsvn.png>
>
> Thanks for reporting back!
> I'm not sure if the scintilla control even supports something like this.
> I have to check that - but don't get your hopes up.
>

I don't think this is scintilla-related:
http://www.microsoft.com/middleeast/msdn/mirror.aspx

Then again, I'm not sure this mirroring technique should be used in an
editable text box.

Could you try setting WS_EX_NOINHERITLAYOUT as well?
(Reminder: revision 9604)

>> 2) Switching from Ctrl+L mode to Ctrl+R keeps the text (but mirrors it).
>> Switching from the Ctrl+R mode back to Ctrl+L deletes the text.
>
> I've seen that too but I don't know why that happens. Seems Scintilla
> has a problem when the window style is changed to RTL and back.
>
>> Thinking forward, perhaps it's a good idea to remember the last-used
>> alignment.
>
> That would not be good, because each project might have different
> settings. If we ever do that, I think it would be better to assign the
> RTL/LTR setting to the tsvn:language property.
>
>> Also, the use of the Ctrl+R_Shift / L_Shift would be more intuitive.
>
> Ctrl + RShift + LShift doesn't change anything on my OS, only Ctrl-R and
> Ctrl-L. That's why I used those.
>
> Stefan
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sat Aug 18 20:29:47 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.