[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: TortoiseMerge window title (issue #345) not fixed in 1.4.4, and a suggestion

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-07-05 18:34:10 CEST

Flavio Stanchina wrote:
> Please apply the fix for issue #345 to the next release, I hoped it went
> into 1.4.4 but it didn't.
> I rebuilt TMerge 1.4.4 with the fix applied, but I noticed that if the
> descriptive name is not set, nothing is shown in the window title.
> Please change CWorkingFile::GetDescriptiveName() to return the file name
> if the descriptive name is empty (see below), or do something similar in
> CTortoiseMergeApp::InitInstance() where you retrieve the descriptive names.
> CString
> CWorkingFile::GetDescriptiveName() const
> {
> if(m_sDescriptiveName.IsEmpty())
> {
> // We don't have a proper name - use the filename part of the path
> return CPathUtils::GetFileNameFromPath(m_sFilename);
> }
> return m_sDescriptiveName;
> }

Issue #345 is not a bug fix but a new feature. And per our rules, only
bugfixes get applied to the stable branches. New features are reserved
for the trunk only.
That means issue #345 won't get merged back to 1.4.x, sorry.

About your request to use the filename if no descriptive name is given:
I have to decline that one too. Because most of the time, we're dealing
with temp files in TSVN. And to use the filename of a tempfile is just
plain ugly and bad - because users will get confused.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Jul 5 18:34:01 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.