RE: TortoiseMerge / TortoiseIDiff am I missing something?

Hi Stefan Küng,

You wrote:

> On 6/20/07, Lübbe Onken <l.onken@rac.de> wrote:
>> Possible improvements:
>> When I select "fit images together", both images are scaled to > 100%
>> Wouldn't it be better to leave the scaling factor of the larger
>> image as it is and only stretch the smaller one to fit the large?
>
> Depends: if the images are bigger than the current window, they're
> scaled to <100%, not >100% :)

I think you understand exactly what I mean :)
 
>> When I zoom in/out after the "stretch", both images are zoomed to
>> absolute values again. IMHO it would be better if the zoom would be
>> applied relative to the "stretch" factor. That's why I also
>> suggested that the stretch option should be a toggle.
...
>> I'd like to be able to stretch -> zoom in -> pan around.
>
> Ok, I have to object now. I definitely won't add yet another button
> for yet another 'fit to ...' function.

Where did I ask fo another button? I just said that the 'fit to ...' button
behaviour should change to a toggle.

> I was more thinking of dropping
> the existing button and only leave the new one (well, combine those
> two: in overlay mode always use the new one, in non-overlay mode use
> the old one).

Agreed yes. We need only one 'fit to...' button (with a toggle function of
course :)). I can imagine it works like this:

Button not pressed (off):
- In normal mode display both images side by side with 100% zoom
- In overlay mode display both images overlayed with 100% zoom

Button pressed (on):
- In normal mode display both images side by side fit to each half window.
May result in different zoom factors for both images.
- In overlay mode display both images overlayed with the larger image scaled
to fit the window and the smaller image scaled to fit the larger images X
axis.

For example consider you compare two images with an aspect ration of 4/3 and
3/4. Both images have the same absolute number of pixels (Image1 800x600 and
Image2 600x800). Now which image is larger? This decision could be made
based upon the scaling factor needed to fit the image into the TortoiseIDiff
client region. The one with the smaller scaling factor is the larger image.

Assume the client region is 800x600.
Image1 has a scaling factor of 1 to fit into the client region
Image2 has a scaling factor of 0.75 to fit into the client region -> image2
is "the larger image". Scaled to fit it will have a size of 450x600. Now
scale Image1 down to x=450. This will result in a scaling factor of 0.56 for
Image1.

Both images will be completely visible after this action. The zoom buttons
should ony be a multiplier to the scaling factors determined by pressing the
'Fit to ...' button.

> This is a simple diff viewer, and I'd like to keep it simple
> if possible.

Too complicated algorithm above?

Cheers
- Lübbe

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org