[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug or Feature? Commit Selection ignored

From: Slim and Steve <slimandsteve_at_gmail.com>
Date: 2007-05-16 15:28:15 CEST

Stefan K√ľng <tortoisesvn <at> gmail.com> writes:

> > A) Just treat the checkmarked/selected files/folders as a list and process
> > just as svn ci -F <filelist> would do. No file system monitoring necessary.
> Not possible. If we would do that, then we'd have to stick to
> non-recursive commits. And non-recursive commits can't commit folder
> deletions.
> --> we *must* commit recursively if the user has everything selected.

I don't know about the internals of TSVN, but with DOS I do a recursive status,
then have a filelist with absolute paths which I can commit with the -F option.
The list in the commit dialog knows about paths, does it? At least the popup
tooltip shows full paths.

> > B) With file system monitoring: on refresh of commit dialog add new modified
> > files *un*selected/checked and issue an alert message so the user can decide
> > to deal with the situation (either commit as selected before or check the
> > list first again.
> I was thinking more of having the monitoring thread set a flag, and
> when the user clicks ok show a message that the contents have changed.
> Automatically refreshing is not good, and interrupting the user with a
> messagebox while he may be writing a log message isn't good either.

Agreed, especially with the last one. How about changing the OK button to
Refresh list in this case? Probably requiring too much knowledge on the average
user's side, wondering where the OK has gone. OTOH the user gets not that much
(non-technical) information either if a commit fails because of an out-of-date
file (forgetting to run update before commit) so he might be glad to read
"refresh" ... ;)


To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed May 16 15:39:15 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.