Re: TortoiseUDiff

On 08/05/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
> Simon Large wrote:
> > Hi folks,
> >
> > Try out the new TortoiseUDiff for looking at unified diffs.
> >
> > Comments on the first version:
> > 1. Esc should close the window.
>
> Done in revision 9358.
>
> > 2. Property diffs are not colourized. Maybe they can't be colourized
> > without some pre-processing (are they presented in unified diff
> > format?). TMerge gets it right.
>
> The property diffs are shown colorized fine? Ok, they're not 'correctly'
> colorized since those diffs lack the context part of unified diffs. But
> that's a limitation of the udiff lexer in Scintilla.

They are colorized, but the file is not a unified diff, so the colours
are misleading. If you look at the r9349 (prop change on
doc/source/en) the properties are multi-line and a new line has been
added. The colours make it look as if the first line has been changed.

I guess what I am saying is that if it can't be colorized correctly,
don't colorize at all.

> Not sure what you mean with "TMerge gets it right" - TMerge doesn't
> colorize at all (apart from added/deleted lines).

I mean TMerge correctly identifies the added line of that property,
but I guess it is just diffing files, not interpreting a unified diff.
Ignore this comment.

> > 3. The title bar shows URL, revs - AppName. As the URL is typically
> > long, it might be more useful to show revs, URL - AppName.
>
> Done in revision 9359.

Simon

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org