Re: [PATCH] Issue 298: Remove parameter /notempfile

Tobias Schäfer wrote:

> this patch finally implements issue 298. I've tested it, but please review.
>
> All details can be found here:
> http://issues.tortoisesvn.net/?do=details&task_id=298

> Index: doc/source/en/TortoiseSVN/tsvn_app_automation.xml
> ===================================================================
> --- doc/source/en/TortoiseSVN/tsvn_app_automation.xml (revision 9012)
> +++ doc/source/en/TortoiseSVN/tsvn_app_automation.xml (working copy)
> @@ -43,11 +43,10 @@
> several paths, separated by a <literal>*</literal> character.
> </para>
> <para>
> - Since TortoiseSVN uses temporary files to pass multiple arguments between
> - the shell extension and the main program, you <emphasis>must</emphasis>
> - add the <option>/notempfile</option> parameter! If you don't, the command
> - won't work and the file you pass with the <option>/path</option> parameter
> - will be deleted!
> + TortoiseSVN uses temporary files to pass multiple arguments between
> + the shell extension and the main program. Since TortoiseSVN 1.5.0 the

Instead of "since TSVN 1.5.0", I think it's better to write:
"From TortoiseSVN 1.5.0 on and later, ..."

> + IDS_ERR_INVALIDPATH "The parameters /path and /pathfile are mutally exclusive."

Maybe better this way:
"The parameters '/path' and '/pathfile' are mutally exclusive.\nYou must
only specify one of them."

(also note: 'mutually', not 'mutally')

> Index: src/TortoiseShell/ContextMenu.cpp
> ===================================================================
> --- src/TortoiseShell/ContextMenu.cpp (revision 9012)
> +++ src/TortoiseShell/ContextMenu.cpp (working copy)
> @@ -1134,9 +1134,12 @@
> CRegStdString tortoiseMergePath(_T("Software\\TortoiseSVN\\TMergePath"), _T("TortoiseMerge.exe"), false, HKEY_LOCAL_MACHINE);
>
> //TortoiseProc expects a command line of the form:
> + //"/command:<commandname> /pathfile:<path> /revstart:<revisionstart> /revend:<revisionend> /deletefile

/deletefile?
Isn't it /deletefilepath?

> + // or
> //"/command:<commandname> /path:<path> /revstart:<revisionstart> /revend:<revisionend>
> - //path is either a path to a single file/directory for commands which only act on single files (log, checkout, ...)
> - //or a path to a temporary file which contains a list of filepaths
> + //
> + //* path is a path to a single file/directory for commands which only act on single files (log, checkout, ...)

single files -> single items
(it acts on files and folders, not just files)

Other than those little nitpicks, the patch is fine!

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org