[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Issue 298: Remove parameter /notempfile

From: Tobias Schäfer <tobiasschaefer_at_gmx.de>
Date: 2007-03-21 19:26:01 CET

Hi,

this patch finally implements issue 298. I've tested it, but please review.

All details can be found here:
http://issues.tortoisesvn.net/?do=details&task_id=298

-------------------------------------------
After some further discussions on the mailing list:

1. The automation interface which is currently
/command:update /path="d:\temp\wc\" /notempfile
changes to
/command:update /path="d:\temp\wc\"
Since the switch /notempfile is not evaluated there won't be a change in
behavior if it is passed. Users using the automation interface cannot
forget /tempfile anymore.

2. The interface for the shell extension is currently
/command:update /path="%temp%\svn1234.tmp"

You (Gavin) propose to change it to:
/command:update /tempfile="%temp%\svn1234.tmp"

If we change the following I (Tobias) agree:
- rename /tempfile to /pathfile to make it clear that /path and /pathfile
are mutally exclusive.
- add a switch to delete the file specified by /pathfile by tortoiseproc
instead of always deleting it. This allows the calling application to
delete the file after having called tortoiseproc.

This is my (Tobias) proposal based on your ideas:
/command:update /pathfile="%temp%\svn1234.tmp" /deletepathfile

This change will break all calls which currently don't specify /notempfile.
All calls from the shell extension will be changed to reflect this new
interface.
-------------------------------------------

Tobias

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Wed Mar 21 19:28:13 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.