Simon Large wrote:
> On Mon Oct 2 5:55 , 'Stefan Küng' sent:
>
>> On 10/1/06, Tobias Schäfer wrote:
>>
>>> I would prefer the revert dialog to behave consistently like all other
>>> dialogs, i.e. select all files by default.
>>>
>>> To make the revert less destructive I propose the following patch.
>>>
>>> It basically moves the files to be reverted to the recyle-bin before calling
>>> the subversion revert function. This makes the subversion library being
>>> called on a missing file instead of on a modified file. The result of the
>>> revert is same except that the previous version can be restored out of the
>>> recycle-bin.
>>> To revert the files without the previous version being placed in the
>>> recyle-bin, just press Shift like in the windows explorer.
>> Worst-case scenario:
>> * user interrupts an ongoing operation (e.g. a commit)
>> * instead of 'cleanup', chooses 'revert' (because he want's to revert
>> what he did to get the working copy locked)
>> * revert fails because wc is locked
>>
>> In the case above, the files would now all be in the trash...
>
> Potentially confusing, but not all bad. The error message on fail will presumably
> say 'use cleanup', and after that using revert or update will bring the BASE or
> HEAD files back. The modified ones will still be in the recycler, which is what
> we want, because the user mistakenly threw away all his changes while tying to do
> a cleanup the wrong way.
Ok, so then I think the patch looks good enough for it to be committed.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Mon Oct 2 18:04:09 2006