[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Re: RFC: Revert folder behaviour change

From: Simon Large <simon_at_skirridsystems.co.uk>
Date: 2006-10-02 12:41:48 CEST
('binary' encoding is not supported, stored as-is) On Mon Oct 2 5:55 , 'Stefan Küng' sent:

>On 10/1/06, Tobias Schäfer wrote:
>
>> I would prefer the revert dialog to behave consistently like all other
>> dialogs, i.e. select all files by default.
>>
>> To make the revert less destructive I propose the following patch.
>>
>> It basically moves the files to be reverted to the recyle-bin before calling
>> the subversion revert function. This makes the subversion library being
>> called on a missing file instead of on a modified file. The result of the
>> revert is same except that the previous version can be restored out of the
>> recycle-bin.
>> To revert the files without the previous version being placed in the
>> recyle-bin, just press Shift like in the windows explorer.
>
>Worst-case scenario:
>* user interrupts an ongoing operation (e.g. a commit)
>* instead of 'cleanup', chooses 'revert' (because he want's to revert
>what he did to get the working copy locked)
>* revert fails because wc is locked
>
>In the case above, the files would now all be in the trash...

Potentially confusing, but not all bad. The error message on fail will presumably
say 'use cleanup', and after that using revert or update will bring the BASE or
HEAD files back. The modified ones will still be in the recycler, which is what
we want, because the user mistakenly threw away all his changes while tying to do
a cleanup the wrong way.

Simon

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Mon Oct 2 12:41:02 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.