Re: Bug: Confirming dialogs despite disabled OK-button

Tobias Schäfer wrote:
> Hi,
>
> normally "Ctrl+Return" can be used to confirm a dialog. This internally
> sends a message to the OK-button, which then executes whatever is
> associated with this OK-button.
>
> The bug: if the ok-button is *disabled* pressing Ctrl+Return executes the
> code associated with th OK-button. I would expect nothing to happen at all.
>
> In most cases (no files selected) this can do no harm. But allowing a commit
> despite not meeting the minimum log size from tsvn:logminsize ist not nice.
>
> The behaviour that a disabled control can react despite being disabled is
> described here:
> msdn.microsoft.com/library/en-us/winui/winui/windowsuserinterface/windowing/windows/windowsfeatures.asp?frame=true
> "A window can be disabled. A disabled window receives no keyboard or mouse
> input from the user, but it can receive messages from other windows, from
> other applications, and from the system."
>
> Actually almost every dialog is affected. The attached patch is for
> discussion only. All other places would need to be fixed the same way.
>
> Should the fix be merged into 1.4.x?

Patch looks good. And yes, I think it should be merged back.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org